Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config/jobs): workaround #1158 #1236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 12, 2023

Proposed way to workaround #1158 , even if this is not a real fix: trigger all build-drivers jobs on any new config.
See #1158 (comment)

PROs:

  • super easy workaround

CONs:

  • we will spawn useless pods
  • we will spawn more nodes than needed

However, please note that:

  • nowadays, since kernel-crawler automation was implemented, we rarely have PRs with a single config being added (it did not happen in 1yr)
  • normally, we trigger the build of drivers when: either the kernel-crawler automation triggers, or we add a new driver version; those jobs normally trigger most of our jobs (~90/100%), therefore spawning all pods in this case would make no real difference
  • Only case where we would scale badly is when we manually run the kernel-crawler automation against a single distro; in this case, instead of only triggering the distro build-drivers jobs, we would trigger all (even if skip existing prevent us from rebuilding everything of course)

In this PR, i trigger indifferently x86_64 and aarch64 jobs, since when eg: we add a new driver version, we basically only trigger aarch64 jobs before the Github API cuts our list of changed files.
In that case, to actually trigger x86_64 jobs, we need this fix.

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 12, 2023

/hold for discussion
/cc @maxgio92 @zuc

@poiana poiana added the size/L label Sep 12, 2023
@poiana poiana requested review from maxgio92 and zuc September 12, 2023 10:38
@FedeDP FedeDP changed the title wip: chore(config/jobs): workaround #1158 chore(config/jobs): workaround #1158 Sep 12, 2023
@poiana
Copy link
Contributor

poiana commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maxgio92
Copy link
Member

@FedeDP see #1158 (comment)

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Mar 17, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Apr 11, 2024

@FedeDP: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
peribolos-syncer-pre-submit-test 3f0d56e link true /test peribolos-syncer-pre-submit-test

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@poiana
Copy link
Contributor

poiana commented May 11, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@FedeDP
Copy link
Contributor Author

FedeDP commented May 13, 2024

/remove-lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Aug 11, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 11, 2024

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants