Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dawn Wallet #162

Merged
merged 18 commits into from
May 11, 2023
Merged

Add Dawn Wallet #162

merged 18 commits into from
May 11, 2023

Conversation

thomas-waite
Copy link
Contributor

@thomas-waite thomas-waite commented Mar 16, 2023 •
edited
Loading

Summary

Integrates Dawn Wallet into ConnectKit. Dawn Wallet is an iOS based Ethereum Wallet, with a native Safari extension: https://twitter.com/dawn_wallet

It is an injected wallet and injects a provider into the web page, through which dapps then prompt connection requests and transaction signing through a Safari popup.

I've tested that this works and you can successfully connect using Dawn across the examples given: nextjs, create react app and vite.

Connect UI looks like:
image

@vercel
Copy link

vercel bot commented Mar 16, 2023

@thomas-waite is attempting to deploy a commit to the LFE Team on Vercel.

A member of the Team first needs to authorize it.

@thomas-waite thomas-waite mentioned this pull request Mar 17, 2023
Merged
@thomas-waite thomas-waite changed the title Integrate Dawn Wallet Add Dawn Wallet Mar 17, 2023
@vercel
Copy link

vercel bot commented Mar 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connectkit-cra ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 6:10am
connectkit-testbench ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 6:10am

@thomas-waite
Copy link
Contributor Author

Dependent on #161 being merged. Needs the wagmi package version 0.12.0 - it has the isDawn flags in

@thomas-waite thomas-waite marked this pull request as ready for review March 29, 2023 22:22
@thomas-waite
Copy link
Contributor Author

Dependent on #161 being merged. Needs the wagmi package version 0.12.0 - it has the isDawn flags in

This is now done, PR ready for review. Have tested it works. The connect UI looks like:

image

@thomas-waite
Copy link
Contributor Author

Hey team, any update on this? Would love to get it merged asap - we're close to being in production

@thomas-waite
Copy link
Contributor Author

Hey team, we're now in production and live on the app store (https://www.dawnwallet.xyz/). Let us know how we can help in getting this merged :)

lochie
lochie approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@lochie lochie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lochie lochie merged commit c79fc74 into family:main May 11, 2023
@lochie
Copy link
Member

lochie commented May 11, 2023

@thomas-waite sorry for the delay on this PR. this will be available in connectkit 1.2.4, we really appreciate the contribution! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lochie lochie lochie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-waite @lochie