add phantom wallet #182
Merged
add phantom wallet #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nheingit is attempting to deploy a commit to the LFE Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lochie
reviewed
Apr 4, 2023
|
looks like phantom name mapping was introduced in wagmi this lgtm now. @nheingit feel free to test on your end and let me know if this is all ready to move forward 😊 |
lochie
approved these changes
May 11, 2023
|
Merging this in, but worth noting that the branding only appears if Phantom is set to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Connectkit team.
I think this is all of the requirements to add a wallet to y'alls codebase.
I wasn't able to actually get Phantom to show up in the example apps after implementing these changes though. is there something I'm missing here? Any help is appreciated