remove throw will always call terminate() warning (facebookincubator#249

) Summary: Pull Request resolved: facebookincubator#249 Remove warnings like ``` gloo/cuda.cu:226:342: warning: throw will always call terminate() [-Wterminate] ``` Reviewed By: serhaty Differential Revision: D20185029 fbshipit-source-id: 6c927f7348f8c9282959cfa7a35601b067bbb5a7
fan1997 · Mar 30, 2020 · e8aaa34 · e8aaa34
1 parent 113bde1
commit e8aaa34
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/gloo/nccl/nccl.cu b/gloo/nccl/nccl.cu
@@ -97,7 +97,7 @@ NCCLExecution<T>::NCCLExecution(std::vector<NCCLElement<T>>&& elements)
 }
 
 template <typename T>
-NCCLExecution<T>::~NCCLExecution() {
+NCCLExecution<T>::~NCCLExecution() noexcept(false) {
   for (auto i = 0; i < this->elements.size(); i++) {
     CudaDeviceScope scope(this->elements[i].device);
     CUDA_CHECK(cudaEventDestroy(ncclEvents[i]));

diff --git a/gloo/nccl/nccl.h b/gloo/nccl/nccl.h
@@ -73,7 +73,7 @@ class NCCLExecution {
  public:
   /* implicit */ NCCLExecution(std::vector<NCCLElement<T>>&& elements);
   NCCLExecution(NCCLExecution&&) = default;
-  ~NCCLExecution();
+  ~NCCLExecution() noexcept(false);
 
   std::vector<int> getDevices() const;
   std::string getKey() const;