Unbreak things

[dead-claudia]

Now the tests actually pass. Apparently, namespacing things apparently was a real breaking change... 😉

[rpominov]

How do you run those tests btw? :)

[dead-claudia]

@rpominov

• Node 6+: nodeunit id_tests.js (it complains about --harmony_destructuring being invalid)
• Node 5 and before: npm test

[dead-claudia]

It basically tests the Id type that comes with this, and verifies that it passes the laws. IIUC it also helps as a sanity check to ensure the laws are actually consistent as well.

[rpominov]

Ah right, there is an npm test script, sorry. And sorry for breaking things :)

[dead-claudia]

@rpominov You're okay. It's just that there isn't CI, and no one until now bothered to run the tests.

(My pun was an attempt to try to take the edge off of things, anyways. 😄)

[rpominov]

Would be cool to setup Travis btw.

[dead-claudia]

Ping @SimonRichardson?

[SimonRichardson]

Travis next 👍

[dead-claudia]

Thanks!

On Mon, Sep 12, 2016, 15:37 Simon Richardson notifications@github.com
wrote:

Travis next 👍

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#157 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AERrBAwsnw-tsATWtCLmzb_-rbvBnpdoks5qpaoCgaJpZM4J58Io
.