-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
favour identifiers a, b, c, and x #90
Conversation
Any changes to |
I'm happy to go further. I don't know whether people are attached to |
I definitely prefer This looks great to me, thanks for your PR! 👍 |
One of Fantasy Land's goals was to remove a lot of the focus and faith put into names. I think we should not care about these names and so it's a little disappointing to see a focus here. But sticking to the principle, I don't care about these names. Feel free to merge 🌵 |
How far would you like us to go, @puffnfresh? For example,
could become:
I see value in using Since no one has objected to the changes made in this pull request, I suggest we merge it as is. I'll then open a separate pull request to remove the beloved |
I don't mean "I don't care, so enumerate them alphabetically" - I mean "I don't care, let them be arbitrary to the reader" |
I'm not sure I grasp your point. Are you saying that the choice of identifiers in Making identifiers arbitrary to the reader is challenging. Arbitrarily chosen values may not appear arbitrary to the reader. The motivation for the pull request was my confusion surrounding There are several ways to encourage readers to see identifiers as arbitrary:
|
|
I think @puffnfresh 's point is the name of an identifier like this doesn't change the semantics. It doesn't matter if the
or
It doesn't change the meaning. |
Maybe what might be better is to give more depth to the explanations. Like for the |
Understood. In this respect this pull request is a no-op. But given two equivalent ways to express a given law we should choose the one less likely to confuse the reader. That's the motivation for this change. |
The reader should not be confused because the reader should not rely on identifier names to understand the laws. I'd rather make that clear than spend effort giving into the pitfall of relying on identifier names for understanding. |
I believe using Presumably Haskell's type signatures use
This is equivalent, but not clearly arbitrary:
I've found this discussion enlightening. I've learnt that the identifiers usually have no inherent meaning ( |
Closes #86