Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Make sure rich_markup_mode=None disables Rich formatting #726

Closed
wants to merge 11 commits into from
Closed

🐛 Make sure rich_markup_mode=None disables Rich formatting #726

wants to merge 11 commits into from

Commits on Dec 22, 2023

  1. make sure rich_markup_mode=None disables rich 

    As stated in the documentation, rich_markup_mode=None is the default
mode. Make sure that this is true even when rich is installed, fix
current tests assuming it's on by default, and add new test cases to
validate rich_markup_mode options.

Signed-off-by: Liam Beguin <liambeguin@gmail.com>

🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
    @liambeguin
    liambeguin committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    1579346 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge branch 'master' into rich_markup_mode

    @svlandeg
    svlandeg committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9983564 View commit details
    Browse the repository at this point in the history

  2. Fix comparison to None

    @svlandeg
    svlandeg committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    111436b View commit details
    Browse the repository at this point in the history

  3. attempt to fix encoding issue

    @svlandeg
    svlandeg committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d830641 View commit details
    Browse the repository at this point in the history

  4. Test that app is running fine

    @svlandeg
    svlandeg committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1c1d195 View commit details
    Browse the repository at this point in the history

  5. Add more tests to ensure 100% coverage

    @svlandeg
    svlandeg committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    076d284 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Use self.rich_markup_mode

    @svlandeg
    svlandeg committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    188768a View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @svlandeg
    svlandeg committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d134841 View commit details
    Browse the repository at this point in the history

  3. Make test robust to whether or not Rich is used

    @svlandeg
    svlandeg committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1942533 View commit details
    Browse the repository at this point in the history

  4. Create full copy of test for more clarity and coverage

    @svlandeg
    svlandeg committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8c21b8d View commit details
    Browse the repository at this point in the history

  5. Make test more robust

    @svlandeg
    svlandeg committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4085304 View commit details
    Browse the repository at this point in the history