-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Ensure rich_markup_mode=None
disables Rich formatting
#859
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2cfd641
Commit failing test
svlandeg fef4a8a
Have default markup mode depending on whether or not rich is installed
svlandeg 74e69af
Fix for mypy
svlandeg 01fef55
Update documentation
svlandeg 16ce4e5
Merge branch 'master' into fix/rich_none
svlandeg 98a8ec0
Merge branch 'master' into fix/rich_none
svlandeg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import typer | ||
import typer.completion | ||
from typer.testing import CliRunner | ||
|
||
runner = CliRunner() | ||
rounded = ["╭", "─", "┬", "╮", "│", "├", "┼", "┤", "╰", "┴", "╯"] | ||
|
||
|
||
def test_rich_markup_mode_none(): | ||
app = typer.Typer(rich_markup_mode=None) | ||
|
||
@app.command() | ||
def main(arg: str): | ||
"""Main function""" | ||
print(f"Hello {arg}") | ||
|
||
assert app.rich_markup_mode is None | ||
|
||
result = runner.invoke(app, ["World"]) | ||
assert "Hello World" in result.stdout | ||
|
||
result = runner.invoke(app, ["--help"]) | ||
assert all(c not in result.stdout for c in rounded) | ||
|
||
|
||
def test_rich_markup_mode_rich(): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test fails with 0.12.5 release
|
||
app = typer.Typer(rich_markup_mode="rich") | ||
|
||
@app.command() | ||
def main(arg: str): | ||
"""Main function""" | ||
print(f"Hello {arg}") | ||
|
||
assert app.rich_markup_mode == "rich" | ||
|
||
result = runner.invoke(app, ["World"]) | ||
assert "Hello World" in result.stdout | ||
|
||
result = runner.invoke(app, ["--help"]) | ||
assert any(c in result.stdout for c in rounded) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test currently fails on
master
, which is clearly a bug IMO.