✨ Remove Rich tags when showing completion text #877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon completion, print the help text with Rich if it's available. Fixes #822.
Original behaviour, as reported in #822: hitting TAB TAB shows the autocompletion with literal Rich formatting, e.g.
With this PR, the Rich tags are removed:
In my experiments, this does not yet actually format the text with the right colors etc. Not sure whether that's due to the shells/OS's I've tried - further input from others using different systems would be appreciated!
Powershell on Windows
master
GitBash using
zsh
shell on WindowsI couldn't yet get this shell to work with Rich formatting - probably because it's an emulated shell.
master