Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test description & change test require style & change case for esm test #181

Merged
merged 3 commits into from
Mar 22, 2022
Merged

test: add test description & change test require style & change case for esm test #181

merged 3 commits into from
Mar 22, 2022

Conversation

xtx1130
Copy link
Contributor

@xtx1130 xtx1130 commented Mar 21, 2022

  • change test case for esm.test.js
  • beauty test cases

Checklist

Eomm
Eomm reviewed Mar 21, 2022
View reviewed changes
test/esm.test.js Outdated Show resolved Hide resolved
xtx1130 and others added 2 commits March 21, 2022 16:05
@xtx1130 @Eomm
Update test/esm.test.js
fefd018 
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
@xtx1130
test: change case for esm test
0fffce5
mcollina
mcollina approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good work!

@Eomm Eomm merged commit 74334bb into fastify:master Mar 22, 2022
@xtx1130 xtx1130 deleted the test-case-change branch March 22, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtx1130 @mcollina @Eomm