feat(tls_activation): support mutual_authentication_id in domain activation at creation #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a (failing) test-case for creating a domain activation with a mutual authentication configuration. Currently the test case fails because the check on the resource shows it does not match the state.
landrew57
force-pushed
the
fix-mutual_authentication_id-set-when-creating
branch
from
583ac5c
to
b6fd587
Compare
The mutual_authentication_id can only be set once an activation has already been created. This commit implements the Update call immediately after the Create call if the mutual_authentication_id is set in the resource configuration. It fixes the failing test case added in the previous commit.
landrew57
force-pushed
the
fix-mutual_authentication_id-set-when-creating
branch
from
b6fd587
to
d7de6a6
Compare
landrew57
changed the title
|
This looks good so far, I'll pull it down to my machine and run the acceptance tests. |
kpfleming
approved these changes
Jul 23, 2024
|
Thank you for the contribution! |
This was referenced Jul 23, 2024
|
Hey @kpfleming do you know when a new release will be available with this change? |
|
We haven't scheduled one yet, but if possible I'll get one made early next week. |
kpfleming
changed the title
|
Version 5.12.0 was just released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails on
mainbecause themutual_authentication_idis not set on an activation when it is createdbut it is set in the terraform state.
mutual_authentication_idcannot be set when activation is createdUpdatethe domain activation once it has been created to add themutual_authentication_idto the configuration.Related to /issues/870 and #873