Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(product_enablement): Add support for NGWAF product. #886

Merged
merged 3 commits into from
Oct 3, 2024
Merged

feat(product_enablement): Add support for NGWAF product. #886

merged 3 commits into from
Oct 3, 2024

Conversation

kpfleming
Copy link
Contributor

No description provided.

BrooksCunningham
BrooksCunningham reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@BrooksCunningham BrooksCunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The only thing that I can see is to use the Product name "Next-Gen WAF" instead of the abbreviation in a couple of places.

fastly/block_fastly_service_product_enablement.go Outdated Show resolved Hide resolved
docs/resources/service_vcl.md Outdated Show resolved Hide resolved
BrooksCunningham
BrooksCunningham approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@BrooksCunningham BrooksCunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpfleming kpfleming merged commit 16467d7 into fastly:main Oct 3, 2024
9 checks passed
@kpfleming kpfleming deleted the cdtool-912 branch October 3, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrooksCunningham BrooksCunningham BrooksCunningham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpfleming @BrooksCunningham