fix for reassign Table Keys faust-streaming#171 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkivikram
reviewed
Jul 20, 2021
faust/stores/memory.py
Outdated
| @@ -31,7 +31,9 @@ def apply_changelog_batch( | |||
| self._create_batch_iterator(to_delete.add, to_key, to_value, batch) | |||
| ) | |||
| for key in to_delete: | |||
| delete_key(key, None) | |||
| # If the key was assigned a value again at a later time, it will not be deleted. | |||
There was a problem hiding this comment.
Could you add a quick unit test to test this?
There was a problem hiding this comment.
I have added a test for this case. Until now there was no test for this use case.
patkivikram
reviewed
Jul 20, 2021
| @@ -31,7 +31,9 @@ def apply_changelog_batch( | |||
| self._create_batch_iterator(to_delete.add, to_key, to_value, batch) | |||
| ) | |||
| for key in to_delete: | |||
| delete_key(key, None) | |||
| # If the key was assigned a value again at a later time, it will not be deleted. | |||
| if not self.data[key]: | |||
There was a problem hiding this comment.
Is this an issue only for memory store? Rocksdb store does not have this issue AFAIK
There was a problem hiding this comment.
The issue is only for memory. When I look into the code for Rocksdb I don't recongnize that there can be the same error
patkivikram
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Fixes #171)
When a key is removed from a table with table.pop(), a changelog entry is sent with a raw null value.
Before this change, on Table recovery, once a key was set to the raw null value, it would be deleted after iterating over the entire Changelog topic.
Now, before deletion, the value for this key is checked to see if it is really null. Otherwise it was assigned to a new value at a later time and will not be deleted