Add back wait_for_stopped_flow #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some use cases for wanting to set a consumer to read from an offset relative to the committed offset, rather than the actual committed offset. This requires stopping the consumer and seeking to the specified offset, but this seek can be overwritten by the else condition of getmany to
perform_seekin case the fetcher returns when the consumer is stopped. To mitigate this, I suggest reintroducing thewait_for_stopped_flowmethod previously introduced to help with the fetcher service race condition. Rather than wait on it explicitly or trying to cancel the fetcher, services can wait for the fetcher to complete normally which shouldn't cause any problems.