Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak open close quickly 93 #133

Merged
merged 5 commits into from
Sep 7, 2020

Conversation

peter-sg
Copy link
Contributor

@peter-sg peter-sg commented Sep 4, 2020

Added a pointer to the timer so that we can cancel it on dispose.
Added the dispose function override
Added if(mounted) check to prevent setState call if the widget has already been disposed.

Copy link
Collaborator

@SebastienBtr SebastienBtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine, it can be merged.

It will close #93 and close #95

@fayeed
Copy link
Owner

fayeed commented Sep 7, 2020

@peter-sg @pycstitch Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling of 'setState' without if(mounted) Memory leak when opening and closing screen or dialog quickly
4 participants