Merge pull request lcompilers#2686 from anutosh491/is_integer

Adding support for is_integer attribute
faze-geek · May 6, 2024 · 41f8d49 · 41f8d49
2 parents 76135f0 + f703bc7
commit 41f8d49
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 1 deletion.
diff --git a/integration_tests/symbolics_02.py b/integration_tests/symbolics_02.py
@@ -98,5 +98,9 @@ def test_symbolic_operations():
     print(b4)
     assert(b4 == False)
 
+    # is_integer check
+    assert(pi1.is_integer == False)
+    assert(a.is_integer == True)
+    assert(c.is_integer == True)
 
 test_symbolic_operations()
diff --git a/src/libasr/pass/intrinsic_function_registry.h b/src/libasr/pass/intrinsic_function_registry.h
@@ -160,6 +160,7 @@ inline std::string get_intrinsic_name(int x) {
         INTRINSIC_NAME_CASE(SymbolicLogQ)
         INTRINSIC_NAME_CASE(SymbolicSinQ)
         INTRINSIC_NAME_CASE(SymbolicGetArgument)
+        INTRINSIC_NAME_CASE(SymbolicIsInteger)
         default : {
             throw LCompilersException("pickle: intrinsic_id not implemented");
         }
@@ -457,6 +458,8 @@ namespace IntrinsicElementalFunctionRegistry {
             {nullptr, &SymbolicSinQ::verify_args}},
         {static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicGetArgument),
             {nullptr, &SymbolicGetArgument::verify_args}},
+        {static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicIsInteger),
+            {nullptr, &SymbolicIsInteger::verify_args}},
     };
 
     static const std::map<int64_t, std::string>& intrinsic_function_id_to_name = {
@@ -742,6 +745,8 @@ namespace IntrinsicElementalFunctionRegistry {
             "SymbolicSinQ"},
         {static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicGetArgument),
             "SymbolicGetArgument"},
+        {static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicIsInteger),
+            "SymbolicIsInteger"},
     };
 
 
@@ -891,6 +896,7 @@ namespace IntrinsicElementalFunctionRegistry {
                 {"LogQ", {&SymbolicLogQ::create_SymbolicLogQ, &SymbolicLogQ::eval_SymbolicLogQ}},
                 {"SinQ", {&SymbolicSinQ::create_SymbolicSinQ, &SymbolicSinQ::eval_SymbolicSinQ}},
                 {"GetArgument", {&SymbolicGetArgument::create_SymbolicGetArgument, &SymbolicGetArgument::eval_SymbolicGetArgument}},
+                {"is_integer", {&SymbolicIsInteger::create_SymbolicIsInteger, &SymbolicIsInteger::eval_SymbolicIsInteger}},
     };
 
     static inline bool is_intrinsic_function(const std::string& name) {

diff --git a/src/libasr/pass/intrinsic_functions.h b/src/libasr/pass/intrinsic_functions.h
@@ -161,6 +161,7 @@ enum class IntrinsicElementalFunctions : int64_t {
     SymbolicLogQ,
     SymbolicSinQ,
     SymbolicGetArgument,
+    SymbolicIsInteger,
     // ...
 };
 
@@ -5853,6 +5854,7 @@ create_symbolic_query_macro(SymbolicMulQ)
 create_symbolic_query_macro(SymbolicPowQ)
 create_symbolic_query_macro(SymbolicLogQ)
 create_symbolic_query_macro(SymbolicSinQ)
+create_symbolic_query_macro(SymbolicIsInteger)
 
 #define create_symbolic_unary_macro(X)                                                    \
 namespace X {                                                                             \

diff --git a/src/libasr/pass/replace_symbolic.cpp b/src/libasr/pass/replace_symbolic.cpp
@@ -279,6 +279,7 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
                 case LCompilers::ASRUtils::IntrinsicElementalFunctions::SymbolicPowQ:
                 case LCompilers::ASRUtils::IntrinsicElementalFunctions::SymbolicLogQ:
                 case LCompilers::ASRUtils::IntrinsicElementalFunctions::SymbolicSinQ:
+                case LCompilers::ASRUtils::IntrinsicElementalFunctions::SymbolicIsInteger:
                     return true;
                 default:
                     return false;
@@ -513,6 +514,7 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
                 BASIC_ATTR(PowQ, 17)
                 BASIC_ATTR(LogQ, 29)
                 BASIC_ATTR(SinQ, 35)
+                BASIC_ATTR(IsInteger, 0)
                 default: {
                     throw LCompilersException("IntrinsicFunction: `"
                         + ASRUtils::get_intrinsic_name(intrinsic_id)

diff --git a/src/lpython/semantics/python_attribute_eval.h b/src/lpython/semantics/python_attribute_eval.h
@@ -48,6 +48,7 @@ struct AttributeHandler {
             {"diff", &eval_symbolic_diff},
             {"expand", &eval_symbolic_expand},
             {"has", &eval_symbolic_has_symbol},
+            {"is_integer", &eval_symbolic_is_integer}
         };
     }
 
@@ -562,6 +563,19 @@ struct AttributeHandler {
         return create_function(al, loc, args_with_list, diag);
     }
 
+    static ASR::asr_t* eval_symbolic_is_integer(ASR::expr_t *s, Allocator &al, const Location &loc,
+            Vec<ASR::expr_t*> &args, diag::Diagnostics &diag) {
+        Vec<ASR::expr_t*> args_with_list;
+        args_with_list.reserve(al, args.size() + 1);
+        args_with_list.push_back(al, s);
+        for(size_t i = 0; i < args.size(); i++) {
+            args_with_list.push_back(al, args[i]);
+        }
+        ASRUtils::create_intrinsic_function create_function =
+            ASRUtils::IntrinsicElementalFunctionRegistry::get_create_function("is_integer");
+        return create_function(al, loc, args_with_list, diag);
+    }
+
 }; // AttributeHandler
 
 } // namespace LCompilers::LPython

diff --git a/src/runtime/lpython/lpython.py b/src/runtime/lpython/lpython.py
@@ -15,6 +15,11 @@
 
 # data-types
 
+def get_sympy_S(x):
+    from sympy import S
+    return S(x)
+
+
 type_to_convert_func = {
     "i1": bool,
     "i8": int,
@@ -34,7 +39,7 @@
     "Callable": lambda x: x,
     "Allocatable": lambda x: x,
     "Pointer": lambda x: x,
-    "S": lambda x: x,
+    "S": get_sympy_S,
 }
 
 class Type: