Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos in 6.1 #11

Merged
merged 1 commit into from
Nov 20, 2017
Merged

typos in 6.1 #11

merged 1 commit into from
Nov 20, 2017

Conversation

hiroyachiba
Copy link

Fixed some typos and bugs.

@hiroyachiba hiroyachiba changed the title typos and bug fixes typos and bug fixes in 6.1, 8.1, 8.2, 8.3 Oct 2, 2017
@fchollet
Copy link
Owner

fchollet commented Oct 2, 2017

Thanks for the PR! Ok for the typos, but the rest of the fixes aren't actual issues. Please restrict this PR to the typos.

@hiroyachiba
Copy link
Author

hiroyachiba commented Oct 2, 2017

First of all, thank you very much for the wonderful book!
Is it better to send small PRs separately?

Let me explain each PRs and could you correct me if I'm wrong?

  1. Use the same seed_text for each temperature.
    In 8.1-text-generation-with-lstm.ipynb,
    All outputs in the book starts from the same seed text (ex. new faculty, and jubilation ...) for each temperature (0.2, 0.5, 1.0) and I thought this is the expected behavior.
    If you run the program (8.1-text-generation-with-lstm.ipynb), the seed text is different for each temparature.

  2. Removed redundant image resize.
    In 8.2-deep-dream.ipynb,
    'resize_img(original_img, shape)' has already been called four lines above, so, no need to call it again.

    same_size_original = resize_img(original_img, shape)
    lost_detail = same_size_original - upscaled_shrunk_original_img

    img += lost_detail
    shrunk_original_img = resize_img(original_img, shape)

  3. 8.3-neural-style-transfer original_image -> target_image, typos
    In 8.3-neural-style-transfer.ipynb,
    'original image' and 'target image' were used to mean the same thing, but
    the real point is the following part is typo.
    "while content(generated_image) would be close to content(generated_image)"

@hiroyachiba hiroyachiba changed the title typos and bug fixes in 6.1, 8.1, 8.2, 8.3 typos in 6.1 Oct 10, 2017
@hiroyachiba
Copy link
Author

Restricted this PR only to typos.

Copy link
Owner

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fchollet fchollet merged commit 8a30b90 into fchollet:master Nov 20, 2017
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

tgotwig pushed a commit to tgotwig/deep-learning-with-python-notebooks that referenced this pull request Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants