Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle networks with multiple NATS #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Stebalien
Copy link

This:

  1. Provides a way to iterate over all discovered NATs.
  2. Tries to pick the best one.

(also fixes possible goroutine leaks when multiple NATs are discovered)

Honestly, the best way to handle mulitple NATs would be to try to configure all of them. However, this is a simpler interim solution.

This change makes it possible to configure all discovered NATs, not just the
first one found.
nat.go Outdated
go func() {
defer close(nats)

ctx, cancel := context.WithCancel(context.Background())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious what is the difference from the first input ctx argument?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants