Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use a new incremental zstd crane mode #3219

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

dpc
Copy link
Contributor

@dpc dpc commented Sep 17, 2023

This greatly decreases the sizes of workspace artifacts that crane produces.

                 before               vs   after
               size       ;   c;   d             size    ;   c;  d
deps-only: 3.59G =>  818 M;  4s;  4s  vs   3.74G =>  818M;  4s; 4s
workspace: 6.33G => 1.96 G;  7s;  7s  vs   2.75G => 1.16G;  3s; 6s

see full analysis.

Re ipetkov/crane#387

@dpc dpc requested review from a team as code owners September 17, 2023 06:46
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07% ⚠️

Comparison is base (293941c) 58.50% compared to head (1fdd290) 58.43%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3219      +/-   ##
==========================================
- Coverage   58.50%   58.43%   -0.07%     
==========================================
  Files         197      197              
  Lines       41265    41265              
==========================================
- Hits        24143    24115      -28     
- Misses      17122    17150      +28     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpc dpc force-pushed the crane-zstd-incremental branch 5 times, most recently from a3e35ef to 93bf6fe Compare September 17, 2023 08:09
@dpc dpc enabled auto-merge September 18, 2023 06:22
@dpc
Copy link
Contributor Author

dpc commented Sep 18, 2023

Even though it's still a PR to crane, the author said it will land, and we can safely use it, as it makes the CI much more lightweight.

This should greatly decrease the sizes of workspace
artifacts that crane produces.

See ipetkov/crane#387
@dpc dpc added this pull request to the merge queue Sep 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2023
@justinmoon justinmoon added this pull request to the merge queue Sep 19, 2023
Merged via the queue into fedimint:master with commit d4bb269 Sep 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants