-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hydrated_bloc): add storage.close #3705
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3705 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 15 3 -12
Lines 328 161 -167
==========================================
- Hits 328 161 -167 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM just left a few minor comments. Let me know what you think, thanks! 🙏
Status
READY
Breaking Changes
NO
Description
Updated
hydrated_bloc
:Storage.close
method added, to allow box to free resources.Type of Change