Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hydrated_bloc): add storage.close #3705

Merged
merged 8 commits into from
Feb 7, 2023
Merged

Conversation

PROGrand
Copy link
Contributor

@PROGrand PROGrand commented Feb 4, 2023

Status

READY

Breaking Changes

NO

Description

Updated hydrated_bloc:

  • Storage.close method added, to allow box to free resources.
  • Fixed tests: removed locked resources conflicts.
  • Increased deps packages versions.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7c668ca) compared to base (2577838).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7c668ca differs from pull request most recent head bc1590b. Consider uploading reports for the commit bc1590b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #3705    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           15         3    -12     
  Lines          328       161   -167     
==========================================
- Hits           328       161   -167     
Impacted Files Coverage Δ
...ckages/hydrated_bloc/lib/src/hydrated_storage.dart 100.00% <100.00%> (ø)
packages/flutter_bloc/lib/src/bloc_builder.dart
packages/flutter_bloc/lib/src/bloc_listener.dart
packages/bloc_test/lib/src/when_listen.dart
packages/replay_bloc/lib/src/replay_bloc.dart
packages/replay_bloc/lib/src/change_stack.dart
packages/replay_bloc/lib/src/replay_cubit.dart
packages/flutter_bloc/lib/src/bloc_selector.dart
packages/flutter_bloc/lib/src/bloc_consumer.dart
...ages/flutter_bloc/lib/src/repository_provider.dart
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PROGrand PROGrand changed the title fix tests, introducing Storage.close hydrated_bloc: fixing tests, introducing Storage.close Feb 4, 2023
@felangel felangel changed the title hydrated_bloc: fixing tests, introducing Storage.close feat(hydrated_bloc): add storage.close Feb 4, 2023
@felangel felangel added enhancement New feature or request pkg:hydrated_bloc This issue is related to the hydrated_bloc package labels Feb 4, 2023
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM just left a few minor comments. Let me know what you think, thanks! 🙏

@felangel felangel merged commit 093f13d into felangel:master Feb 7, 2023
@felangel felangel mentioned this pull request Feb 7, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:hydrated_bloc This issue is related to the hydrated_bloc package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants