minor optimizations

feresr · Aug 22, 2020 · 065810b · 065810b
1 parent 56f5c81
commit 065810b
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 17 deletions.
diff --git a/include/ecs/ecs.h b/include/ecs/ecs.h
@@ -176,9 +176,14 @@ class World {
         for (auto entity : entities) if (entity->has<Components...>()) callback(entity);
     }
 
+    template<typename... Components>
+    void findAny(const std::function<void(Entity*)>& callback) {
+        for (auto entity : entities) if (entity->hasAny<Components...>()) callback(entity);
+    }
+
     template<typename... Components>
     std::vector<Entity*> findAny() {
-        // todo: Optimize, avoid creating a new vector an returning it by copy
+        //todo: optimize, this should return an iterator and not a new vector
         std::vector<Entity*> result;
         std::copy_if(
                 entities.begin(),

diff --git a/src/systems/CallbackSystem.cpp b/src/systems/CallbackSystem.cpp
@@ -5,15 +5,15 @@ void CallbackSystem::onAddedToWorld(World* world) {
 }
 
 void CallbackSystem::tick(World* world) {
-    for (auto entities : world->find<CallbackComponent>()) {
-        auto callback = entities->get<CallbackComponent>();
-        if (callback->time <= 0) {
-            entities->remove<CallbackComponent>();
-            continue;
+    world->find<CallbackComponent>([](Entity* entity){
+        auto callback = entity->get<CallbackComponent>();
+        if (callback->time > 0) {
+            callback->time--;
+            if (callback->time == 0) callback->callback();
+        } else {
+            entity->remove<CallbackComponent>();
         }
-        callback->time--;
-        if (callback->time <= 0) callback->callback();
-    }
+    });
 }
 
 void CallbackSystem::handleEvent(SDL_Event& event) {

diff --git a/src/systems/PlayerSystem.cpp b/src/systems/PlayerSystem.cpp
@@ -95,13 +95,14 @@ void PlayerSystem::onGameOver(World* world, Entity* player) {
     kinetic->accY = 0.0f;
     kinetic->accX = 0.0f;
 
-    for (auto walkable : world->findAny<WalkComponent, KineticComponent>()) {
-        if (walkable == player) continue;
-        walkable->remove<WalkComponent>();
-        walkable->remove<KineticComponent>();
-        walkable->remove<AnimationComponent>();
-        walkable->remove<CallbackComponent>();
-    }
+    world->findAny<WalkComponent, KineticComponent>([=](Entity* walker) {
+        if (walker != player) {
+            walker->remove<WalkComponent>();
+            walker->remove<KineticComponent>();
+            walker->remove<AnimationComponent>();
+            walker->remove<CallbackComponent>();
+        }
+    });
 
     player->assign<CallbackComponent>([=]() {
         player->remove<SolidComponent>();
@@ -110,7 +111,7 @@ void PlayerSystem::onGameOver(World* world, Entity* player) {
         kinetic->accY = 0.0f;
         kinetic->accX = 0.0f;
 
-        player->assign<CallbackComponent>([=]() { gameOverCallback(); }, 200);
+        player->assign<CallbackComponent>([&]() { gameOverCallback(); }, 200);
     }, 50);
 }