fix: feature detection for Google Chrome #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old version did not check if chrome.sockets.udp actually exist. This caused problems with extensions built for Chromium-based browsers that tried to maintain the single codebase and do feature-detection at runtime. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Sep 9, 2019
Improved detection of chrome.sockets.udp feross/chrome-dgram#16
17 tasks
|
3.0.3 |
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Sep 11, 2019
Improved detection of chrome.sockets.udp feross/chrome-dgram#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds explicit check if
chrome.sockets.udpexist before registering related listeners.Why?
chrome-dgramdid not check ifchrome.sockets.udpAPIs actually exist, which caused problems in browser extensions, making it difficult to maintain a single codebase and do feature-detection at runtime (namely, Google Chrome withoutchrome.sockets.udpvs Brave with).Refs. feross/chrome-net#36, ipfs/ipfs-companion#664 ipfs/ipfs-companion#716