stb#250 Create initial tests for refarm_redirects app #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duker33
force-pushed
the
stb250_too_many_redirects
branch
from
b28756d
to
f7507b1
Compare
ArtemijRodionov
requested changes
Jul 22, 2018
tests/refarm_redirects/test_views.py
Outdated
| It should meet db constraint while adding. | ||
| """ | ||
| # hardcoded fixtures will be fixed with task in test ahead. | ||
| url_from, url_to = 2 * ['/catalog/categories/category-0/tags/6-v/'] |
There was a problem hiding this comment.
url_from = url_to = '/catalog/categories/category-0/tags/6-v/'
tests/refarm_redirects/test_views.py
Outdated
|
|
||
| # `url_from` should redirect to `url_to` | ||
| response = self.client.get(url_from) | ||
| self.assertEqual(response.status_code, 200) |
There was a problem hiding this comment.
Seems we should test here the occurrence of an error after Redirect.objects.create(...) instead of this
ArtemijRodionov
approved these changes
Jul 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes fidals/stroyprombeton#250
Closes #151