Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VM trait #1340

Merged
merged 7 commits into from
Jul 31, 2023
Merged

Update VM trait #1340

merged 7 commits into from
Jul 31, 2023

Conversation

alexytsu
Copy link
Contributor

@alexytsu alexytsu commented Jul 24, 2023

  • update VM trait to align with anorth/fvm-workbench

Some methods that were previously on the abstract VM are deemed specific to the implementation of the TestVM in builtin-actors. To ease alignment with VM implementations in other contexts such as https://github.com/anorth/fvm-workbench, certain methods have been removed from the trait such as those relating to builtin-actors' notion of Policy and actor manifest.

@alexytsu alexytsu requested a review from anorth July 24, 2023 03:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Merging #1340 (76c83cf) into master (a77674d) will decrease coverage by 0.06%.
The diff coverage is 73.80%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   90.84%   90.79%   -0.06%     
==========================================
  Files         138      139       +1     
  Lines       27350    27351       +1     
==========================================
- Hits        24847    24832      -15     
- Misses       2503     2519      +16     
Files Changed Coverage Δ
test_vm/src/vm.rs 43.47% <43.47%> (ø)
test_vm/src/lib.rs 82.68% <82.35%> (+0.35%) ⬆️
state/src/check.rs 86.08% <100.00%> (-0.27%) ⬇️
test_vm/src/util/mod.rs 99.42% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There's some deconflicting to do with #1343 and follow up to cut clean deps, but that looks easy enough from here.

test_vm/src/lib.rs Outdated Show resolved Hide resolved
@alexytsu alexytsu enabled auto-merge July 31, 2023 00:12
@alexytsu alexytsu added this pull request to the merge queue Jul 31, 2023
Merged via the queue into master with commit 64a103e Jul 31, 2023
13 checks passed
@alexytsu alexytsu deleted the alexytsu/update-vm-trait branch July 31, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants