Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feature: move partition (#1326)" #1480

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

aarshkshah1992
Copy link
Contributor

This reverts #1326.

@arajasek
Copy link
Contributor

Context: The current actors code has a bug. We don't strictly need to land this (we can just fix the bug), or we can land this revert and reintroduce it with the necessary fix.

@arajasek
Copy link
Contributor

Context: The current actors code has a bug. We don't strictly need to land this (we can just fix the bug), or we can land this revert and reintroduce it with the necessary fix.

@anorth I'll let you make the final decision on this -- my suggestion would be to land this, and reintroduce #1326 with the appropriate fix. But if you'd like to just open a fix PR against master and land that, I have no objection to that.

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs #1482 to be incorporated into thish

@anorth
Copy link
Member

anorth commented Nov 14, 2023

It does depend on which solution path we choose, but I concur that while that's not clear, let's revert the feature on master (by landing this) and then develop the solution back on the integration branch.

@aarshkshah1992
Copy link
Contributor Author

@arajasek I've addressed your request. Please can you review ?

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aarshkshah1992 aarshkshah1992 added this pull request to the merge queue Dec 12, 2023
Merged via the queue into master with commit 81595c2 Dec 12, 2023
14 checks passed
@aarshkshah1992 aarshkshah1992 deleted the revert/move-partitions-1326 branch December 12, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants