-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Feature: move partition (#1326)" #1480
Conversation
This reverts commit 5ec2a6b.
Context: The current actors code has a bug. We don't strictly need to land this (we can just fix the bug), or we can land this revert and reintroduce it with the necessary fix. |
@anorth I'll let you make the final decision on this -- my suggestion would be to land this, and reintroduce #1326 with the appropriate fix. But if you'd like to just open a fix PR against master and land that, I have no objection to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs #1482 to be incorporated into thish
It does depend on which solution path we choose, but I concur that while that's not clear, let's revert the feature on master (by landing this) and then develop the solution back on the integration branch. |
@arajasek I've addressed your request. Please can you review ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This reverts #1326.