Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of toEthAddress #16

Closed
wants to merge 13 commits into from

Conversation

vonum
Copy link
Collaborator

@vonum vonum commented Sep 6, 2023

Test for fil address lib:

  1. toEthAddress
  2. fromEthAddress

Refactored toEthAddress implementation.

@wertikalk wertikalk self-assigned this Sep 27, 2023
Copy link
Collaborator

@scotthconner scotthconner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing fuzzing, but I still don't see legit existing cases of f1,f2, etc. For instance, where are the tests that take a hard coded value (an f0 or f1 address), that is actually not fuzzed, and legitimately tests it for a specific output?

@vaniiiii
Copy link
Collaborator

Moved to #23

@wertikalk wertikalk deleted the fil-address-tests branch November 15, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants