feat: add stable etag #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
willscott
approved these changes
Jun 2, 2023
Merged
kylehuntsman
approved these changes
Jun 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 71.19% 72.02% +0.83%
==========================================
Files 70 70
Lines 6283 6391 +108
==========================================
+ Hits 4473 4603 +130
+ Misses 1556 1539 -17
+ Partials 254 249 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ipfs/boxo@f61f954#r1213918777
I'm not a great fan of the CID being in the hashed bit, but I believe that's what ipfs/boxo#303 is currently doing and it'd be nice to hamonise one way or the other, and it's not particularly wasteful to include it.