feat: Events API enabled by default if EnableEthRPC is true #10077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
gstuart/eth-event-config
branch
from
433723e
to
a5316dd
Compare
raulk
reviewed
Jan 19, 2023
node/config/types.go
Outdated
Comment on lines
664
to
665
| // EnableEthRPC enables APIs that can create and query filters for actor events as they are emitted. | ||
| // DisableRealTimeFilterAPI will disable those APIs if you want to opt-out |
geoff-vball
force-pushed
the
gstuart/eth-event-config
branch
2 times, most recently
from
d3f0829
to
1a426ff
Compare
travisperson
approved these changes
Jan 19, 2023
geoff-vball
force-pushed
the
gstuart/eth-event-config
branch
from
1a426ff
to
ee7d29c
Compare
jennijuju
reviewed
Jan 19, 2023
node/config/def.go
Outdated
| MaxFilters: 100, | ||
| MaxFilterResults: 10000, | ||
| MaxFilterHeightRange: 2880, // conservative limit of one day | ||
| Events: EventsConfig{ |
There was a problem hiding this comment.
hrm @raulk - I thought we agreed to move this section under FEVM ? then the rename make sense cuz its FEVM.Events?
There was a problem hiding this comment.
Yes, I believe this makes sense for now. While the Events subsystem is technically independent of FEVM, this is a user-facing configuration file and I think it leads to better product usability for node operators if all the new options they care about are nested within the Fevm group. We might need to rejigger this when builtin-actors are emitting events or with Wasm actors, but we can cross that bridge when we get to it, because I expect changes in the event subsystem anyway.
geoff-vball
force-pushed
the
gstuart/eth-event-config
branch
from
ee7d29c
to
2894eb2
Compare
…ableEthRPC is set
geoff-vball
force-pushed
the
gstuart/eth-event-config
branch
from
2894eb2
to
6601d90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Sets a default path for the Events Database to be in the same directory as the tx hash database.
Enables all event API functionality if EnableEthRPC is set to true, otherwise it is always disabled.
Changes the Event Config to allow opt-out of these event APIs
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps