fix: eth: return the correct nonce from EthGetTransactionCount #10300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVM contracts track this number internally. fixes #10255
Stebalien
force-pushed
the
steb/fix-eth-nonce
branch
from
88f9b9d
to
a3bc65b
Compare
| @@ -367,6 +368,29 @@ func (a *EthModule) EthGetTransactionCount(ctx context.Context, sender ethtypes. | |||
| return ethtypes.EthUint64(0), xerrors.Errorf("cannot parse block param: %s", blkParam) | |||
| } | |||
|
|
|||
| // First, handle the case where the "sender" is an EVM actor. | |||
There was a problem hiding this comment.
this comment should be on line 380?
There was a problem hiding this comment.
It's the entire section. I've put it into a block to make that clear.
There was a problem hiding this comment.
Eh, I switched it to an if chain.
shrenujbansal
approved these changes
Feb 17, 2023
arajasek
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes #10255
Proposed Changes
In EthGetTransactionCount, get the "correct" nonce for EVM contracts in case someone is using this method to, e.g., predict CREATE addresses.
EVM contracts track this number internally.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps