Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api: Clean API for Miners #12112

Merged
merged 30 commits into from
Jul 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
156dda9
proofparams alternate
snadrus Jun 19, 2024
f6d4075
createminer
snadrus Jun 19, 2024
b10c5ff
const factored from /build and types updated to use it
snadrus Jun 20, 2024
f4cf250
buildconstants for more places
snadrus Jun 20, 2024
08f126c
deprecate msg
snadrus Jun 20, 2024
36772b5
itest cleanup
snadrus Jun 20, 2024
66c9252
alerting interface
snadrus Jun 20, 2024
883469a
house cleaning
snadrus Jun 20, 2024
856ea4b
rm policy and drand from buildconstants
snadrus Jun 20, 2024
8d8894a
clean up curio further
snadrus Jun 20, 2024
35602b4
Merge branch 'master' into curioAvoidBuildFolder
snadrus Jun 20, 2024
ee8226e
aussie waffle
snadrus Jun 20, 2024
f1a6572
pr fixes
snadrus Jun 21, 2024
fc36dcc
fix lints
snadrus Jun 21, 2024
7a1cc4d
little fixes
snadrus Jun 24, 2024
ca58e1a
Merge branch 'master' into curioAvoidBuildFolder
snadrus Jul 11, 2024
3b0fecd
oops this got updated
snadrus Jul 11, 2024
12ba6f2
unbreak test builds
snadrus Jul 11, 2024
2217b86
test fixes
snadrus Jul 11, 2024
795a865
comments - cleanups
snadrus Jul 12, 2024
81387ca
itests fix alerting
snadrus Jul 12, 2024
7272177
rm obsolete alertinginterface
snadrus Jul 12, 2024
7639a07
spelling oops
snadrus Jul 12, 2024
d0eb1dc
Merge branch 'master' into curioAvoidBuildFolder
snadrus Jul 12, 2024
320c31f
changelog
snadrus Jul 12, 2024
86b9797
tests need buildconstants port
snadrus Jul 12, 2024
20947d2
Fully migrate BlockGasTarget
snadrus Jul 12, 2024
21ca683
ulimit should not depend on build
snadrus Jul 12, 2024
bec5965
complete the simplest deprecations
snadrus Jul 12, 2024
3d830f0
bringing back versions
snadrus Jul 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test fixes
  • Loading branch information
snadrus committed Jul 11, 2024
commit 2217b862836c875c1745b233484a87aac318894c
2 changes: 1 addition & 1 deletion api/api_full.go
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@ type FullNode interface {
// newLeaseExpiration cannot be further than 5 minutes in the future.
// It is recommended to call F3Participate every 60 seconds
// with newLeaseExpiration set 2min into the future.
// The oldLeaseExpiration has to be set to newLeaseExpiration of the last successfull call.
// The oldLeaseExpiration has to be set to newLeaseExpiration of the last successful call.
// For the first call to F3Participate, set the oldLeaseExpiration to zero value/time in the past.
// F3Participate will return true if the lease was accepted.
// The minerID has to be the ID address of the miner.
Expand Down
2 changes: 1 addition & 1 deletion build/openrpc/full.json
Original file line number Diff line number Diff line change
Expand Up @@ -6588,7 +6588,7 @@
{
"name": "Filecoin.F3Participate",
"description": "```go\nfunc (s *FullNodeStruct) F3Participate(p0 context.Context, p1 address.Address, p2 time.Time, p3 time.Time) (bool, error) {\n\tif s.Internal.F3Participate == nil {\n\t\treturn false, ErrNotSupported\n\t}\n\treturn s.Internal.F3Participate(p0, p1, p2, p3)\n}\n```",
"summary": "F3Participate should be called by a storage provider to participate in signing F3 consensus.\nCalling this API gives the lotus node a lease to sign in F3 on behalf of given SP.\nThe lease should be active only on one node. The lease will expire at the newLeaseExpiration.\nTo continue participating in F3 with the given node, call F3Participate again before\nthe newLeaseExpiration time.\nnewLeaseExpiration cannot be further than 5 minutes in the future.\nIt is recommended to call F3Participate every 60 seconds\nwith newLeaseExpiration set 2min into the future.\nThe oldLeaseExpiration has to be set to newLeaseExpiration of the last successfull call.\nFor the first call to F3Participate, set the oldLeaseExpiration to zero value/time in the past.\nF3Participate will return true if the lease was accepted.\nThe minerID has to be the ID address of the miner.\n",
"summary": "F3Participate should be called by a storage provider to participate in signing F3 consensus.\nCalling this API gives the lotus node a lease to sign in F3 on behalf of given SP.\nThe lease should be active only on one node. The lease will expire at the newLeaseExpiration.\nTo continue participating in F3 with the given node, call F3Participate again before\nthe newLeaseExpiration time.\nnewLeaseExpiration cannot be further than 5 minutes in the future.\nIt is recommended to call F3Participate every 60 seconds\nwith newLeaseExpiration set 2min into the future.\nThe oldLeaseExpiration has to be set to newLeaseExpiration of the last successful call.\nFor the first call to F3Participate, set the oldLeaseExpiration to zero value/time in the past.\nF3Participate will return true if the lease was accepted.\nThe minerID has to be the ID address of the miner.\n",
"paramStructure": "by-position",
"params": [
{
Expand Down
2 changes: 1 addition & 1 deletion documentation/en/api-v1-unstable-methods.md
Original file line number Diff line number Diff line change
Expand Up @@ -2331,7 +2331,7 @@ the newLeaseExpiration time.
newLeaseExpiration cannot be further than 5 minutes in the future.
It is recommended to call F3Participate every 60 seconds
with newLeaseExpiration set 2min into the future.
The oldLeaseExpiration has to be set to newLeaseExpiration of the last successfull call.
The oldLeaseExpiration has to be set to newLeaseExpiration of the last successful call.
For the first call to F3Participate, set the oldLeaseExpiration to zero value/time in the past.
F3Participate will return true if the lease was accepted.
The minerID has to be the ID address of the miner.
Expand Down
2 changes: 1 addition & 1 deletion node/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ func defaults() []Option {
// global system journal.
Override(new(journal.DisabledEvents), journal.EnvDisabledEvents),
Override(new(journal.Journal), modules.OpenFilesystemJournal),
Override(new(*alerting.Alerting), alerting.NewAlertingSystem),
Override(new(alerting.Alerting), alerting.NewAlertingSystem),
snadrus marked this conversation as resolved.
Show resolved Hide resolved
Override(new(alertinginterface.AlertingInterface), alerting.NewAlertingSystem),
Override(new(dtypes.NodeStartTime), FromVal(dtypes.NodeStartTime(time.Now()))),

Expand Down
Loading