Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: v1.27.2 #12249

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Release: v1.27.2 #12249

merged 2 commits into from
Jul 17, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jul 17, 2024

[This release] contains an upgraded libp2p to v0.35.3 which is included in this release for additional testing of some fixes that may solve some connectivity problems experienced by some users (See libp2p/go-libp2p#2858 for more information).

We'd like to use this release for some early testing of the libp2p upgrade before it goes out in the v1.28.0 final release.

@rvagg rvagg requested a review from rjan90 July 17, 2024 07:24
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added nit on the changelog, but apart from that it looks good

@rvagg rvagg merged commit c63213c into release/v1.27.2 Jul 17, 2024
84 of 85 checks passed
@rvagg rvagg deleted the rvagg/v1.27.2 branch July 17, 2024 07:46
@rvagg rvagg mentioned this pull request Jul 17, 2024
@rvagg
Copy link
Member Author

rvagg commented Jul 17, 2024

Post-mortem items:

  • This required a further merge of release/v1.27.2 into the releases branch to finalise Release: v1.27.2 #12250, which is different from RC builds. This is as designed but needs to change for v1.28.0 forward because we are not using the releases branch for that.
  • This created miner builds and a miner release: https://github.com/filecoin-project/lotus/releases/tag/untagged-086fb5cb1c887e1c1658, although the release page is mostly empty except for some titles and the build assets. I cancelled the miner release step before it did its thing so we haven't pushed that: https://github.com/filecoin-project/lotus/actions/runs/9972453588/job/27556032962
  • The release page it posted had two titles and two contributor tables; one taken from the CHANGELOG and one generated. The contributors table that was generated was more correct although the title wasn't an h2 (##), I forgot to redo it. But I edited the release page after the draft was created, but when it did the final release it overwrote my edits so I have to edit it again. It would be good if the draft could be used to get it right before it's pushed to the wild since some people get the original via email or other notification where the edits won't be seen after publish.
Screenshot 2024-07-17 at 8 33 34 PM Screenshot 2024-07-17 at 8 33 54 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants