Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docs: Update step in skeleton guide #12349

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Aug 7, 2024

Proposed Changes

Updating the instructions for integrating the network skeleton into Lotus. Instead of manually modifying the go.mod file to use a local clone of go-state-types, the updated instructions now direct to the "Update Dependencies Lotus" tutorial for steps on updating dependencies that has been released

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Update CHANGELOG.md or signal that this change does not need it.
    • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
    • If the change does not require a CHANGELOG.md entry, do one of the following:
      • Add [skip changelog] to the PR title
      • Add the label skip/changelog to the PR
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

chore: docs: Update dependencies in Lotus
@rjan90 rjan90 requested a review from rvagg August 7, 2024 07:16
Co-authored-by: Rod Vagg <rod@vagg.org>
@rjan90 rjan90 enabled auto-merge (squash) August 7, 2024 07:20
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Aug 7, 2024
@rjan90 rjan90 merged commit 4b75fa8 into master Aug 7, 2024
83 checks passed
@rjan90 rjan90 deleted the phi/network-skeleton branch August 7, 2024 07:27
rjan90 added a commit that referenced this pull request Aug 12, 2024
* chore: docs: Update dependencies in Lotus

chore: docs: Update dependencies in Lotus

* Update documentation/misc/Building_a_network_skeleton.md

Co-authored-by: Rod Vagg <rod@vagg.org>

---------

Co-authored-by: Rod Vagg <rod@vagg.org>
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 20, 2024
* chore: docs: Update dependencies in Lotus

chore: docs: Update dependencies in Lotus

* Update documentation/misc/Building_a_network_skeleton.md

Co-authored-by: Rod Vagg <rod@vagg.org>

---------

Co-authored-by: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants