Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] feat(f3): override F3BootstrapEpoch on 2k devnet with environment variable #12354

Merged

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Aug 7, 2024

Related Issues

Proposed Changes

To facilitate local and CI testing for F3 on forest side, this PR adds environment variables to override F3Enabled and F3BootstrapEpcoh on 2k devnet. (just like how network upgrade epochs can be overridden with environment variables)

(Skipping changelog as similar LOTUS_{NETWORK}_HEIGHT changes do not present in CHANGELOG.md)

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Update CHANGELOG.md or signal that this change does not need it.
    • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
    • If the change does not require a CHANGELOG.md entry, do one of the following:
      • Add [skip changelog] to the PR title
      • Add the label skip/changelog to the PR
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@hanabi1224 hanabi1224 changed the title feat: f3: override F3BootstrapEpoch on 2k devnet with environment variable [skip changelog]feat: f3: override F3BootstrapEpoch on 2k devnet with environment variable Aug 7, 2024
@hanabi1224 hanabi1224 marked this pull request as ready for review August 7, 2024 14:02
@rjan90 rjan90 requested a review from masih August 8, 2024 15:39
@rjan90
Copy link
Contributor

rjan90 commented Aug 9, 2024

PR Title Check / Check PR Title (pull_request) Failing after 2s

It seems like this check is failing due to GitHub's security restrictions on Actions running on PRs from forks. I will adjust the workflow accordingly today, so that we can land this with a completely green CI.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjan90 rjan90 force-pushed the hm/2k-override-f3-bootstrap-epoch branch from 5b2d660 to ec3842e Compare August 12, 2024 06:21
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjan90 rjan90 changed the title [skip changelog]feat: f3: override F3BootstrapEpoch on 2k devnet with environment variable [skip changelog] feat(f3): override F3BootstrapEpoch on 2k devnet with environment variable Aug 12, 2024
@github-actions github-actions bot dismissed their stale review August 12, 2024 06:21

PR title now matches the required format.

@rjan90 rjan90 dismissed GitHub Actions’s stale review August 12, 2024 06:24

PR title now matches the required format.

@rjan90
Copy link
Contributor

rjan90 commented Aug 12, 2024

I looked at the failing "PR Title Check" despite conforming to our conventions. The issue stems from the recent change in our workflow to allow running on PRs from forks:

  • We switched from pull_request to pull_request_target to support checking PR titles from forks: fix(ci): support checking forks in PR-title check workflow #12367
  • This PR was submitted during the transition period.
  • As a result, two "PR Title Check" workflows were running in this PR:
    • The old Check PR Title (pull_request) workflow (now obsolete) is failing.
    • The new pull_request_target workflow is passing.

It's safe to ignore the failing check from the obsolete workflow. Apologies for the confusion and noise in your PR.

@rjan90 rjan90 merged commit f9074a6 into filecoin-project:master Aug 12, 2024
169 of 175 checks passed
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants