Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: f3: update go-f3 to 0.2.0 #12390

Merged
merged 3 commits into from
Aug 15, 2024
Merged

feat: f3: update go-f3 to 0.2.0 #12390

merged 3 commits into from
Aug 15, 2024

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Aug 14, 2024

Includes:

  • fix for excessive bandwidth usage
  • significant performance improvements
  • minor F3 consensus fixes

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

Includes:
 - fix for excessive bandwidth usage
 - significant performance improvements
 - minor consensus fixes

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kubuxu Kubuxu changed the title Update go-f3 to 0.2.0 f3: dep: Update go-f3 to 0.2.0 Aug 14, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kubuxu Kubuxu changed the title f3: dep: Update go-f3 to 0.2.0 feat(f3): Update go-f3 to 0.2.0 Aug 14, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Aug 14, 2024

🤷 no idea why it is is still angry

@masih masih changed the title feat(f3): Update go-f3 to 0.2.0 feat: f3: Update go-f3 to 0.2.0 Aug 14, 2024
@github-actions github-actions bot dismissed their stale review August 14, 2024 19:49

PR title now matches the required format.

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Aug 14, 2024

That is different than what is in the doc: https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions

@jennijuju jennijuju mentioned this pull request Aug 15, 2024
2 tasks
@rvagg rvagg changed the title feat: f3: Update go-f3 to 0.2.0 feat: f3: update go-f3 to 0.2.0 Aug 15, 2024
@github-actions github-actions bot dismissed their stale review August 15, 2024 06:46

PR title now matches the required format.

@rvagg
Copy link
Member

rvagg commented Aug 15, 2024

@Kubuxu lower-case description .. I'm sure that was in there originally; @rjan90 where did that go in that doc?

@rjan90
Copy link
Contributor

rjan90 commented Aug 15, 2024

@Kubuxu lower-case description .. I'm sure that was in there originally; @rjan90 where did that go in that doc?

It originally said it in the comment like so: #12340 (review) - but we missed brining that over to the https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions. Will add

@rjan90 rjan90 marked this pull request as ready for review August 15, 2024 15:06
@rjan90 rjan90 requested a review from Stebalien August 15, 2024 15:07
@Kubuxu
Copy link
Contributor Author

Kubuxu commented Aug 15, 2024

@rvagg @rjan90 what threw me for a loop is this in docs <type>(<scope>): <description> while the CI checks for: : : `

@Kubuxu Kubuxu merged commit 59fe7e3 into master Aug 15, 2024
104 checks passed
@Kubuxu Kubuxu deleted the upd/f3-0.2.0 branch August 15, 2024 15:09
rjan90 pushed a commit that referenced this pull request Aug 15, 2024
* Update go-f3 to 0.2.0

Includes:
 - fix for excessive bandwidth usage
 - significant performance improvements
 - minor consensus fixes

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>

* add changelog

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>

* chore(f3): update to final released version

---------

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Co-authored-by: Steven Allen <steven@stebalien.com>
jennijuju pushed a commit that referenced this pull request Aug 15, 2024
* Update go-f3 to 0.2.0

Includes:
 - fix for excessive bandwidth usage
 - significant performance improvements
 - minor consensus fixes

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>

* add changelog

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>

* chore(f3): update to final released version

---------

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Co-authored-by: Steven Allen <steven@stebalien.com>
rjan90 added a commit that referenced this pull request Aug 19, 2024
…lease) (#12400)

* fix: lotus-miner: remove provecommit1 method (#12251)

* remove provecommit1

* add changelog

* update precommit and commit params

* fix lint error

* fix commit params

* dep: f3: Update go-f3 to 0.0.6, enable it on mainnet (#12295)

* Update go-f3 to 0.0.6

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>

* Enable F3 in passive configuration in mainnet config

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>

* Add changelog

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>

* add new butterfly assets

---------

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Co-authored-by: Jennifer Wang <jiayingw703@gmail.com>

* retract v1.28.0

* update v1.28.0 changelog and add v1.28.1

* Update CHANGELOG.md

* wip - update f3

* don't convert bigint type

We now use the same one in GPBFT.

* update docs

* fix wrong param name

* update butterfy assets

* update go-f3

* update changelog

* update version

* fix typo

* Update CHANGELOG.md

Co-authored-by: Steven Allen <steven@stebalien.com>

* Update CHANGELOG.md

Co-authored-by: Rod Vagg <rod@vagg.org>

* Update CHANGELOG.md

Co-authored-by: Rod Vagg <rod@vagg.org>

* apply f3 patch

* chore: bump versions and make gen/docsgen-cli

chore: bump versions and make gen/docsgen-cli

* chore: update v1.28.2 changelog

chore: update v1.282. changelog

* feat: f3: update go-f3 to 0.2.0 (#12390)

* Update go-f3 to 0.2.0

Includes:
 - fix for excessive bandwidth usage
 - significant performance improvements
 - minor consensus fixes

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>

* add changelog

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>

* chore(f3): update to final released version

---------

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Co-authored-by: Steven Allen <steven@stebalien.com>

* fix!: sealer: handle initialisation error without panic

storage/pipeline.NewPreCommitBatcher and storage/pipeline.New now have an additional
error return to deal with errors arising from fetching the sealing config.

* add breaking API upgrade warning to the ChangeLog

* NewCommitBatcher now has an additional
error return to deal with errors arising from fetching the sealing config.

* fix: miner: Fix DDO pledge math (#12341)

* Power is units of Space * Time so multiply by deal duration

* fix: miner: Fix DDO pledge math

* appease the changelog checker

* Fix gen

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

* chore: fix lint error

- Updated the logging statement in `testOutOfGasError` to correctly reference `build.BlockGasLimit` instead of `buildconstants.BlockGasLimit`.

* fix: update changelog to reference bandwidth issue ticket

fix: update changelog to reference bandwidth issue ticket

* Update CHANGELOG.md

Co-authored-by: Steve Loeppky <biglep@filoz.org>

* Update CHANGELOG.md

* chore: make gen and make docsgen-cli

Run `make gen` and `make docsgen-cli`

---------

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com>
Co-authored-by: Jakub Sztandera <oss@kubuxu.com>
Co-authored-by: Jennifer Wang <jiayingw703@gmail.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Steven Allen <steven@stebalien.com>
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: aarshkshah1992 <aarshkshah1992@gmail.com>
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
Co-authored-by: Steve Loeppky <biglep@filoz.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants