This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: improve error reporting when port is in use #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, when we could not start listening on webserver's TCP port, the binary produced by GoReleaser would abort with no meaningful error report: ``` ❯ ./build/saturn/l2node-darwin-arm64/saturn-l2 [1] 16654 killed ./build/saturn/l2node-darwin-arm64/saturn-l2 ``` In this commit, I am reworking error handling to print the error to stderr and exit the process with a non-zero exit code via `os.Exit`. Signed-off-by: Miroslav Bajtoš <saturn@bajtos.net>
bajtos
force-pushed
the
fix/cannot-listen-error
branch
from
7239c2e
to
bac721b
Compare
|
So the crash was not caused by |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when we could not start listening on webserver's TCP port, the binary produced by GoReleaser would abort with no meaningful error report:
In this commit, I am reworking error handling to print the error to stderr and exit the process with a non-zero exit code via
os.Exit.