This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
add latency / size metrics for error cases #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
fix/error-metrics
branch
from
855d1c7
to
49f5801
Compare
lidel
force-pushed
the
fix/error-metrics
branch
from
49f5801
to
05bb6a7
Compare
lidel
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
lgtm (it was bit hairy so cleaned it up, and deduplicated calculation between logs and metrics)
ps. I think "Speed" one may not be correctly represented at bifrost-gw-staging-metrics, Y-axis should be something like bytes/second, and not seconds(?). (will update staging to ipfs-inactive/bifrost-gateway@e4d22d2 binary with this PR, and we will ping George later this week if its still wonky)
| goLogger.Debugw("fetch result", "from", from, "of", c, "status", code, "size", received, "ttfb", int(fb.Sub(start).Milliseconds()), "duration", time.Since(start).Seconds()) | ||
| ttfbMs := fb.Sub(start).Milliseconds() | ||
| durationSecs := time.Since(start).Seconds() | ||
| goLogger.Debugw("fetch result", "from", from, "of", c, "status", code, "size", received, "ttfb", int(ttfbMs), "duration", durationSecs, "attempt", attempt, "error", e) |
There was a problem hiding this comment.
ℹ️ replaced two debugs logs per request with one (success will have error equal null here)
lidel
added a commit
to ipfs-inactive/bifrost-gateway
that referenced
this pull request
Feb 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
report these even in error cases