-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated conversion config to include feature request, column conversi…
…on logic and bug_report. (#255) Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
- Loading branch information
1 parent
2352e85
commit ac60af5
Showing
3 changed files
with
79 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
name: Add/Modify conversion config | ||
about: Community proposal to add / enhance a column conversion config for a provider | ||
title: "[Proposal] Title for proposal" | ||
labels: proposal | ||
assignees: '' | ||
|
||
--- | ||
|
||
### Provider | ||
> Provider type (e.g. AWS, GCP etc.) | ||
### Column | ||
> Column name | ||
### A SQL query or example steps to transform | ||
|
||
|
||
### Context / Supporting information | ||
>Description of the conversion logic |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Describe the bug** | ||
A clear and concise description of what the bug is. | ||
|
||
**To Reproduce** | ||
Steps to reproduce the behavior: | ||
1. Load a sample cost dataset as provider | ||
2. Run conversion | ||
3. If runs but produces incorrect result, run sql query on dataset using | ||
``` | ||
import polars as pl | ||
lf = pl.scan_parquet(<path_to_converted_data>) | ||
sql_context = SQLFunctions.create_sql_context(lf=lf) | ||
df = sql_context.execute(sql_query, eager=False).collect() | ||
print(df.select(["column1", ...]).limit(10) | ||
``` | ||
|
||
**Expected behavior** | ||
Value format/value type. | ||
|
||
**Screenshots** | ||
If applicable, add screenshots to help explain your problem. | ||
|
||
**Desktop (please complete the following information):** | ||
- OS: [e.g. iOS] | ||
- Converter version [e.g. 0.7] | ||
- Focus Spec Version [e.g. 1.0] | ||
|
||
**Additional context** | ||
Add any other context about the problem here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Is your feature request related to a problem? Please describe.** | ||
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
|
||
**Describe the solution you'd like** | ||
A clear and concise description of what you want to happen. | ||
|
||
**Describe alternatives you've considered** | ||
A clear and concise description of any alternative solutions or features you've considered. | ||
|
||
**Additional context** | ||
Add any other context or screenshots about the feature request here. |