Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix a typo on aws category mapping filename #160

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion focus_converter_base/docs/notebooks/writing_configs.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"conversion_type: lookup\n",
"focus_column: ServiceCategory\n",
"conversion_args:\n",
" reference_dataset_path: \"conversion_configs/aws/mapping_files/aws_catergory_mapping.csv\"\n",
" reference_dataset_path: \"conversion_configs/aws/mapping_files/aws_category_mapping.csv\"\n",
" source_value: product_code\n",
" destination_value: aws_category\n",
"\"\"\""
Expand Down
10 changes: 5 additions & 5 deletions focus_converter_base/docs/operations/lookup.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ Here's an overview of each key-value pair in the YAML configuration:

## Steps to Create the Configuration

1. **Prepare the Reference Dataset**: Ensure "aws_catergory_mapping.csv" is ready and accessible in the specified
path (`"conversion_configs/aws/mapping_files/aws_catergory_mapping.csv"`). This file should contain at least two
1. **Prepare the Reference Dataset**: Ensure "aws_category_mapping.csv" is ready and accessible in the specified
path (`"conversion_configs/aws/mapping_files/aws_category_mapping.csv"`). This file should contain at least two
columns: one for the AWS product code (`product_code`) and one for the corresponding AWS service
category (`aws_category`).

Expand All @@ -40,7 +40,7 @@ column: line_item_product_code
conversion_type: lookup
focus_column: ServiceCategory
conversion_args:
reference_dataset_path: "conversion_configs/aws/mapping_files/aws_catergory_mapping.csv"
reference_dataset_path: "conversion_configs/aws/mapping_files/aws_category_mapping.csv"
source_value: product_code
destination_value: aws_category
```
Expand All @@ -49,7 +49,7 @@ conversion_args:
- **Invalid YAML Syntax**: YAML is sensitive to formatting and especially indentation. If you encounter syntax errors,
double-check your indentations and ensure you're using spaces, not tabs.
- **File Not Found Errors**: If the system reports that it cannot find "aws_catergory_mapping.csv," verify that
- **File Not Found Errors**: If the system reports that it cannot find "aws_category_mapping.csv," verify that
the `reference_dataset_path` is correct and the file is accessible.
- **Incorrect Mappings**: If the `ServiceCategory` values don't seem to match what's expected, ensure that
the `source_value` and `destination_value` correctly correspond to the columns in "aws_catergory_mapping.csv".
the `source_value` and `destination_value` correctly correspond to the columns in "aws_category_mapping.csv".
4 changes: 2 additions & 2 deletions focus_converter_base/docs/writing_configs.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

- Basic knowledge of YAML syntax.
- Access to the system or application that uses this configuration.
- The reference dataset "aws_catergory_mapping.csv" should be available at the specified path.
- The reference dataset "aws_category_mapping.csv" should be available at the specified path.

#### Operation documentation examples

Expand All @@ -29,4 +29,4 @@

#### Sample notebook showing the workflow of how to write conversion configs.

Notebook [writing_config.ipnyb](notebooks/writing_configs.ipynb)
Notebook [writing_config.ipnyb](notebooks/writing_configs.ipynb)
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ column: line_item_product_code
conversion_type: lookup
focus_column: ServiceCategory
conversion_args:
reference_dataset_path: "conversion_configs/aws/mapping_files/aws_catergory_mapping.csv"
reference_dataset_path: "conversion_configs/aws/mapping_files/aws_category_mapping.csv"
source_value: product_code
destination_value: aws_category
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def test_lookup_file_from_package(self):
conversion_type: lookup
focus_column: Region
conversion_args:
reference_dataset_path: conversion_configs/aws/mapping_files/aws_catergory_mapping.csv
reference_dataset_path: conversion_configs/aws/mapping_files/aws_category_mapping.csv
source_value: a
destination_value: b
reference_path_in_package: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def test_lookup_plan(
dimension_id=sample_dimension_id,
conversion_args=LookupConversionArgs(
destination_value="product_code",
reference_dataset_path="conversion_configs/aws/mapping_files/aws_catergory_mapping.csv",
reference_dataset_path="conversion_configs/aws/mapping_files/aws_category_mapping.csv",
source_value="product_code",
),
)
Expand Down
Loading