Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to password policy validation #2227

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Fixes to password policy validation #2227

merged 5 commits into from
Jun 27, 2023

Conversation

kevinthecheung
Copy link
Contributor

@kevinthecheung kevinthecheung commented Jun 27, 2023

  • Reorder checks so that you can pass undefined to use defaults
  • Fix some 'undefined' comparisons

@kevinthecheung kevinthecheung marked this pull request as ready for review June 27, 2023 20:45
pragatimodi and others added 2 commits June 27, 2023 13:49
* Adding TotpInfo to userRecord

* Changing type from `any` to `unknown` for type safety.

* Addressing feedback
@kevinthecheung kevinthecheung requested review from lahirumaramba and removed request for prameshj June 27, 2023 20:54
@pragatimodi
Copy link
Contributor

LGTM, thank you for finding these!

@kevinthecheung kevinthecheung merged commit 64f0336 into master Jun 27, 2023
@kevinthecheung kevinthecheung deleted the kc-passwd-policy branch June 27, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants