feat(fcm): Add HTTP2 support for sendEach() and sendEachForMulticast()
#2550
Conversation
jonathanedey
changed the title
sendEach() and sendEachForMulticastsendEach() and sendEachForMulticast()
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lahirumaramba
changed the title
sendEach() and sendEachForMulticast()sendEach() and sendEachForMulticast()
|
Thanks Jonathan! Let's make the changes we discussed in the API proposal and do another pass. We should be good to go then! |
| * ``` | ||
| * | ||
| * @deprecated This is to be removed once the HTTP/2 transport is universally safe. | ||
| */ |
There was a problem hiding this comment.
Can we get a TW review on this?
src/messaging/messaging.ts
Outdated
| * messaging.sendEach(messages); | ||
| * ``` | ||
| * | ||
| * @deprecated This is to be removed once the HTTP/2 transport is universally safe. |
There was a problem hiding this comment.
This is to be removed once the HTTP/2 transport implementation is universally safe. ?
There was a problem hiding this comment.
Yeah, I'm not crazy about that wording either. Can we give a more concrete criteria than safety?
There was a problem hiding this comment.
Safe here was to imply when the HTTP/2 implementation was stable enough where it was on par with the HTTP/1.1 implementation and no longer needed an emergency back up in case some functionality was completely covered.
Went with the following but open to any suggestions here:
This is to be removed once the HTTP/2 transport implementation reaches the same stability as the legacy HTTP/1.1 implementation.
There was a problem hiding this comment.
That works for me!
If it's easily done, I'd tone down to "This will be removed when..."
src/messaging/messaging.ts
Outdated
| * messaging.sendEach(messages); | ||
| * ``` | ||
| * | ||
| * @deprecated This is to be removed once the HTTP/2 transport is universally safe. |
There was a problem hiding this comment.
Yeah, I'm not crazy about that wording either. Can we give a more concrete criteria than safety?
Added:
sendEach()andsendEachForMulitcast()enableLegacyTransport()When sending messages using
sendEach()orsendEachForMulitcast()a HTTP/2 connection is now used by default.In order to use the legacy HTTP/1.1 versions of these methods, the
enableLegacyTransport()method must be used. This method is already marked as deprecated and will be removed once the HTTP/2 transport is considered fully stable.Related: #2488