Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #4011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update package.json #4011

wants to merge 1 commit into from

Conversation

PutziSan
Copy link

add needed peerDependencies (@firebase/app and @firebase/app-types) and mark them as optional (to omit the warning in firebase-admin)

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

closes #3707

add needed peerDependencies  (@firebase/app and @firebase/app-types) and mark them as optional (to omit the warning in firebase-admin)
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2020

⚠️ No Changeset found

Latest commit: 5b4a539

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla
Copy link

google-cla bot commented Oct 29, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@PutziSan
Copy link
Author

@googlebot I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Make firebase compatible with Yarn2 pnp
1 participant