Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Extract Firestore IDB wrapper to util #6129

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

WIP: Extract Firestore IDB wrapper to util #6129

wants to merge 13 commits into from

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Apr 7, 2022

No description provided.

@hsubox76 hsubox76 requested a review from allspain as a code owner April 7, 2022 21:17
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2a75119

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as draft April 7, 2022 21:19
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 8, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/database

    TypeBase (d756f4e)Merge (753164b)Diff
    browser247 kB247 kB-77 B (-0.0%)
    esm5275 kB275 kB-77 B (-0.0%)
    main280 kB280 kB-67 B (-0.0%)
    module247 kB247 kB-77 B (-0.0%)

  • @firebase/database-compat/standalone

    TypeBase (d756f4e)Merge (753164b)Diff
    main369 kB369 kB-67 B (-0.0%)

  • @firebase/firestore

    TypeBase (d756f4e)Merge (753164b)Diff
    browser252 kB246 kB-5.99 kB (-2.4%)
    esm5313 kB304 kB-8.17 kB (-2.6%)
    main503 kB491 kB-12.5 kB (-2.5%)
    module252 kB246 kB-5.99 kB (-2.4%)
    react-native252 kB246 kB-5.99 kB (-2.4%)

  • @firebase/firestore-lite

    TypeBase (d756f4e)Merge (753164b)Diff
    browser73.2 kB73.2 kB+2 B (+0.0%)
    esm586.6 kB86.6 kB+45 B (+0.1%)
    main126 kB126 kB-79 B (-0.1%)
    module73.2 kB73.2 kB+2 B (+0.0%)
    react-native73.4 kB73.4 kB+21 B (+0.0%)

  • @firebase/util

    TypeBase (d756f4e)Merge (753164b)Diff
    browser23.4 kB37.4 kB+14.0 kB (+59.8%)
    esm525.5 kB42.9 kB+17.4 kB (+68.3%)
    main30.5 kB48.7 kB+18.2 kB (+59.5%)
    module23.4 kB37.4 kB+14.0 kB (+59.8%)

  • bundle

    17 size changes

    TypeBase (d756f4e)Merge (753164b)Diff
    database (Append to a list of data)143 kB143 kB-18 B (-0.0%)
    database (Filtering data)142 kB142 kB-18 B (-0.0%)
    database (Listen for child events)158 kB158 kB-18 B (-0.0%)
    database (Listen for value events + Detach listeners)158 kB158 kB-18 B (-0.0%)
    database (Listen for value events)158 kB158 kB-18 B (-0.0%)
    database (Read data once)150 kB150 kB-18 B (-0.0%)
    database (Save data as transactions)160 kB160 kB-18 B (-0.0%)
    database (Sort data)144 kB144 kB-18 B (-0.0%)
    database (Write data)143 kB143 kB-18 B (-0.0%)
    firestore (Persistence)262 kB264 kB+1.55 kB (+0.6%)
    firestore (Query Cursors)202 kB203 kB+242 B (+0.1%)
    firestore (Query)203 kB204 kB+242 B (+0.1%)
    firestore (Read data once)192 kB192 kB+242 B (+0.1%)
    firestore (Realtime updates)194 kB194 kB+242 B (+0.1%)
    firestore (Transaction)176 kB177 kB+252 B (+0.1%)
    firestore (Write data)176 kB176 kB+250 B (+0.1%)
    firestore-lite (Transaction)71.2 kB71.2 kB+6 B (+0.0%)

  • firebase

    TypeBase (d756f4e)Merge (753164b)Diff
    firebase-auth-react-native.js492 kB529 kB+37.5 kB (+7.6%)
    firebase-compat.js778 kB779 kB+938 B (+0.1%)
    firebase-database-compat.js165 kB165 kB-76 B (-0.0%)
    firebase-database.js603 kB603 kB-155 B (-0.0%)
    firebase-firestore-compat.js303 kB305 kB+1.28 kB (+0.4%)
    firebase-firestore-lite.js250 kB249 kB-1.26 kB (-0.5%)
    firebase-firestore.js820 kB839 kB+18.5 kB (+2.3%)
    firebase-performance-standalone-compat.js64.0 kB71.3 kB+7.32 kB (+11.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cJyTjXZ1Zo.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 8, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (918,549 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WhWOy0Sflf.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allspain allspain Awaiting requested review from allspain

@maneesht maneesht Awaiting requested review from maneesht maneesht will be requested when the pull request is marked ready for review maneesht is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g will be requested when the pull request is marked ready for review aashishpatil-g is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsubox76 @google-oss-bot