Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forced RTDB to adhere to valid types #6726

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Forced RTDB to adhere to valid types #6726

wants to merge 6 commits into from

Conversation

maneesht
Copy link
Contributor

Attempt to fix #5526

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: d10065a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 25, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/messaging

    TypeBase (8f031b4)Merge (15ef658)Diff
    browser21.3 kB21.4 kB+94 B (+0.4%)
    esm526.7 kB26.8 kB+92 B (+0.3%)
    main27.4 kB27.5 kB+92 B (+0.3%)
    module21.3 kB21.4 kB+94 B (+0.4%)

  • @firebase/messaging-sw

    TypeBase (8f031b4)Merge (15ef658)Diff
    main30.1 kB30.2 kB+92 B (+0.3%)
    module23.3 kB23.4 kB+94 B (+0.4%)

  • @firebase/performance

    TypeBase (8f031b4)Merge (15ef658)Diff
    browser29.1 kB29.1 kB+40 B (+0.1%)
    esm530.8 kB30.8 kB+40 B (+0.1%)
    main31.2 kB31.3 kB+40 B (+0.1%)
    module29.1 kB29.1 kB+40 B (+0.1%)

  • bundle

    TypeBase (8f031b4)Merge (15ef658)Diff
    messaging (send + receive)46.3 kB46.4 kB+58 B (+0.1%)
    performance (trace)50.8 kB50.8 kB+24 B (+0.0%)

  • firebase

    TypeBase (8f031b4)Merge (15ef658)Diff
    firebase-compat.js740 kB740 kB+104 B (+0.0%)
    firebase-messaging-compat.js38.2 kB38.3 kB+98 B (+0.3%)
    firebase-messaging-sw.js26.0 kB26.0 kB+55 B (+0.2%)
    firebase-messaging.js24.8 kB24.9 kB+55 B (+0.2%)
    firebase-performance-compat.js30.7 kB30.7 kB+6 B (+0.0%)
    firebase-performance-standalone-compat.es2017.js90.0 kB90.0 kB+13 B (+0.0%)
    firebase-performance-standalone-compat.js66.5 kB66.5 kB+6 B (+0.0%)
    firebase-performance.js30.7 kB30.7 kB+13 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bxkQ6ufkQf.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 25, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/messaging

    • deleteToken

      Size

      TypeBase (8f031b4)Merge (15ef658)Diff
      size12.7 kB12.8 kB+58 B (+0.5%)
      size-with-ext-deps38.5 kB38.5 kB+58 B (+0.2%)

    • getMessaging

      Size

      TypeBase (8f031b4)Merge (15ef658)Diff
      size13.2 kB13.2 kB+58 B (+0.4%)
      size-with-ext-deps46.0 kB46.1 kB+58 B (+0.1%)

    • getToken

      Size

      TypeBase (8f031b4)Merge (15ef658)Diff
      size12.6 kB12.7 kB+58 B (+0.5%)
      size-with-ext-deps38.3 kB38.4 kB+58 B (+0.2%)

    • isSupported

      Size

      TypeBase (8f031b4)Merge (15ef658)Diff
      size13.0 kB13.0 kB+58 B (+0.4%)
      size-with-ext-deps38.6 kB38.7 kB+58 B (+0.2%)

    • onMessage

      Size

      TypeBase (8f031b4)Merge (15ef658)Diff
      size12.7 kB12.8 kB+58 B (+0.5%)
      size-with-ext-deps38.5 kB38.5 kB+58 B (+0.2%)

  • @firebase/performance

    • getPerformance

      Size

      TypeBase (8f031b4)Merge (15ef658)Diff
      size18.0 kB18.0 kB+24 B (+0.1%)
      size-with-ext-deps50.7 kB50.7 kB+24 B (+0.0%)

    • initializePerformance

      Size

      TypeBase (8f031b4)Merge (15ef658)Diff
      size18.2 kB18.2 kB+24 B (+0.1%)
      size-with-ext-deps44.1 kB44.1 kB+24 B (+0.1%)

    • trace

      Size

      TypeBase (8f031b4)Merge (15ef658)Diff
      size17.9 kB17.9 kB+24 B (+0.1%)
      size-with-ext-deps43.5 kB43.5 kB+24 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iQIIXevArC.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g will be requested when the pull request is marked ready for review aashishpatil-g is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTDB should use JSON types instead of any
2 participants
@maneesht @google-oss-bot