Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to retry unauthorized requests #8351

Open
wants to merge 4 commits into
base: dataconnect
Choose a base branch
from
Open

Added ability to retry unauthorized requests #8351

wants to merge 4 commits into from

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Jul 3, 2024

Made sure that any time the server responds with unauthenticated, we do a forceToken refresh and retry as long as the token is new.

@maneesht maneesht requested a review from a team as a code owner July 3, 2024 23:08
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b39b8cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maneesht maneesht requested review from dconeybe and removed request for a team July 3, 2024 23:08
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 3, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/data-connect

    TypeBase (4254b10)Merge (1c2b61c)Diff
    browser16.2 kB16.8 kB+571 B (+3.5%)
    esm518.2 kB18.9 kB+733 B (+4.0%)
    main20.2 kB20.9 kB+733 B (+3.6%)
    module16.2 kB16.8 kB+571 B (+3.5%)

  • firebase

    TypeBase (4254b10)Merge (1c2b61c)Diff
    firebase-data-connect.js14.1 kB14.4 kB+366 B (+2.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TIafsz8iuc.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 3, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/data-connect

    • DataConnect

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.44 kB9.84 kB+397 B (+4.2%)
      size-with-ext-deps27.4 kB27.8 kB+401 B (+1.5%)

    • FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.47 kB9.87 kB+397 B (+4.2%)
      size-with-ext-deps27.5 kB27.9 kB+401 B (+1.5%)

    • FirebaseAuthProvider

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.45 kB9.85 kB+397 B (+4.2%)
      size-with-ext-deps27.4 kB27.8 kB+401 B (+1.5%)

    • MUTATION_STR

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.46 kB9.86 kB+397 B (+4.2%)
      size-with-ext-deps27.5 kB27.9 kB+401 B (+1.5%)

    • MutationManager

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.45 kB9.84 kB+397 B (+4.2%)
      size-with-ext-deps27.4 kB27.8 kB+401 B (+1.5%)

    • QUERY_STR

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.44 kB9.84 kB+397 B (+4.2%)
      size-with-ext-deps27.4 kB27.8 kB+401 B (+1.5%)

    • SOURCE_CACHE

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.44 kB9.84 kB+397 B (+4.2%)
      size-with-ext-deps27.4 kB27.8 kB+401 B (+1.5%)

    • SOURCE_SERVER

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.44 kB9.84 kB+397 B (+4.2%)
      size-with-ext-deps27.4 kB27.8 kB+401 B (+1.5%)

    • connectDataConnectEmulator

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.53 kB9.93 kB+397 B (+4.2%)
      size-with-ext-deps27.5 kB27.9 kB+401 B (+1.5%)

    • executeMutation

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.52 kB9.91 kB+397 B (+4.2%)
      size-with-ext-deps27.5 kB27.9 kB+401 B (+1.5%)

    • executeQuery

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.51 kB9.91 kB+397 B (+4.2%)
      size-with-ext-deps27.5 kB27.9 kB+401 B (+1.5%)

    • getDataConnect

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.93 kB10.3 kB+397 B (+4.0%)
      size-with-ext-deps35.0 kB35.4 kB+401 B (+1.1%)

    • mutationRef

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.56 kB9.96 kB+397 B (+4.2%)
      size-with-ext-deps27.6 kB28.0 kB+401 B (+1.5%)

    • parseOptions

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.44 kB9.84 kB+397 B (+4.2%)
      size-with-ext-deps27.4 kB27.8 kB+401 B (+1.5%)

    • queryRef

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.56 kB9.96 kB+397 B (+4.2%)
      size-with-ext-deps27.6 kB28.0 kB+401 B (+1.5%)

    • setLogLevel

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.47 kB9.87 kB+397 B (+4.2%)
      size-with-ext-deps27.5 kB27.9 kB+401 B (+1.5%)

    • subscribe

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size10.5 kB10.9 kB+397 B (+3.8%)
      size-with-ext-deps35.6 kB36.0 kB+401 B (+1.1%)

    • terminate

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size9.47 kB9.87 kB+397 B (+4.2%)
      size-with-ext-deps27.5 kB27.9 kB+401 B (+1.5%)

    • toQueryRef

      Size

      TypeBase (4254b10)Merge (1c2b61c)Diff
      size10.1 kB10.5 kB+397 B (+3.9%)
      size-with-ext-deps35.2 kB35.6 kB+401 B (+1.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fkS2BnOR4k.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconeybe dconeybe Awaiting requested review from dconeybe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maneesht @google-oss-bot