Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugbash fixes #3644

Merged
merged 4 commits into from
Aug 6, 2021
Merged

Bugbash fixes #3644

merged 4 commits into from
Aug 6, 2021

Conversation

inlined
Copy link
Member

@inlined inlined commented Aug 6, 2021

  1. Fix a bug where we printed [Object object] instead of a valid function ID
  2. Ensure all new API dependencies are enabled on project deploys
  3. Disable the import eslint module per github.com/no-unresolved is not aware of exports definition in package.json import-js/eslint-plugin-import#1810

The import module does not currenty handle package exports.
The author is apparently of the opinion that exports should not
use renaming features. Until this is fixed, all of the v2
API is broken.

See import-js/eslint-plugin-import#1810
for more info.
@inlined inlined requested review from mbleigh and taeold August 6, 2021 00:18
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Aug 6, 2021
@inlined inlined merged commit a8835e8 into master Aug 6, 2021
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
* Print function names on validation errors, not [Object object]

* Require all necessary APIs

* Remove import eslint module

The import module does not currenty handle package exports.
The author is apparently of the opinion that exports should not
use renaming features. Until this is fixed, all of the v2
API is broken.

See import-js/eslint-plugin-import#1810
for more info.

* Linter fixes
@bkendall bkendall deleted the inlined.bugbash-fixes branch March 18, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants