-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(firebase_dynamic_links): pass through
utmParameters
on iOS
an…
…d make property on `PendingDynamicLinkData`. (#8232)
- Loading branch information
1 parent
433a08e
commit 32d06e7
Showing
3 changed files
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32d06e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@russellwheatley
utmParameters is Map<String, String>;
but linkData['utmParameters'] is <Object?, Object?>
when i try use utmParameters i got an error
Unhandled Exception: type '_InternalLinkedHashMap<Object?, Object?>' is not a subtype of type 'Map<String, String>' #0 MethodChannelFirebaseDynamicLinks._getPendingDynamicLinkDataFromMap (package:firebase_dynamic_links_platform_interface/src/method_channel/method_channel_firebase_dynamic_links.dart:107:30) #1 MethodChannelFirebaseDynamicLinks.getInitialLink (package:firebase_dynamic_links_platform_interface/src/method_channel/method_channel_firebase_dynamic_links.dart:120:14)
32d06e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest update is breaking the app silently. I was wondering why the stream subscription (FirebaseDynamicLinks.instance.onLink.listen(...) was not being invoked whilst using dynamic links but there was no error or exception until I switched on all exceptions which showed: "type '_InternalLinkedHashMap<Object?, Object?>' is not a subtype of type 'Map<String, String>'".
Would really appreciate if this can be fixed and latest upgrade pushed to pub.dev?
Thanks
32d06e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm this error is occurring on iOS (12.5.5) with a real device on release build.
32d06e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Occurs for me too. Temporal fix: change pubspec.yaml