[Go] improve API #523
Merged
[Go] improve API #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR consists solely of refactoring. There are no behavior changes. Address the following warts on the API: - Although flows are a key concept in Genkit, and the genkit package includes a DefineFlow function, the Flow type itself lived in the core package. - The core package contained several exported methods that were intended only to be called by the genkit package, a clear sign that something is off in the API design. The actual visible changes to achieve this are small, but a lot of code was moved. Most of the changes involve moving unexported symbols into internal packages so they could be used by other packages. The main API changes are: - Flow is now in the genkit package. - There are no more InternalXXX symbols in core. There are some other minor changes, like the removal of the NoStream type.
randall77
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists solely of refactoring. There are no behavior changes.
Address the following warts on the API:
Although flows are a key concept in Genkit, and the genkit package
includes a DefineFlow function, the Flow type itself lived in the core
package.
The core package contained several exported methods that were intended
only to be called by the genkit package, a clear sign that something
is off in the API design.
The actual visible changes to achieve this are small, but a lot of
code was moved. Most of the changes involve moving unexported symbols
into internal packages so they could be used by other packages.
The main API changes are:
Flow is now in the genkit package.
There are no more InternalXXX symbols in core.
There are some other minor changes, like the removal of the NoStream
type.