Framework icons only load on file openings and cause visual jitter

[digitarald]

Adding jitter to #6725, which was about the tabs.

STR:

• Open Debugger on https://debugger-example-typescript-react.glitch.me/
• Open of the ts files in webpack

React icon loads after the file loaded, with layout jitter in the source pane.

[darkwing]

My understanding is that we don't know about placing the React icon until we analyze the source, which I don't believe we load until the tab is opened.

I suppose we could automagically assign that icon for tsx files (?)

[jasonLaster]

Yeah, i think we can do three things:

1. assign it based on tsx, jsx
2. persist the information on load
3. do something special with original files [1]

[1] the client has the original source text in the map, which means that we do not need to load the source text from the server. At that point, the only slowdown is parsing the file to determine the framework. I think we can probably stop parsing the file and instead rely on a couple of regexes, which is what the editors do as well.

When we have sourcemap support on the server, it will be easier to identify frameworks for generated files before "load" as well.

[nchevobbe]

Could we have a transparent item that takes the place of the possible future icon ? This way it doesn't "jump" when the icon is displayed. Le sam. 4 août 2018 à 18:02, Jason Laster <notifications@github.com> a écrit :

…

Yeah, i think we can do three things: 1. assign it based on tsx, jsx 2. persist the information on load 3. do something special with original files [1] [1] the client has the original source text in the map, which means that we do not need to load the source text from the server. At that point, the only slowdown is parsing the file to determine the framework. I think we can probably stop parsing the file and instead rely on a couple of regexes, which is what the editors do as well. When we have sourcemap support on the server, it will be easier to identify frameworks for generated files before "load" as well. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6753 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjSO5LDVnmZoWoJvpO_iS-OngfgtpGmks5uNcWBgaJpZM4Vu2co> .

[jasonLaster]

The jump is because a tab with an icon in ~15px wider. I think it would look off to have the 15px and no tab.

[jasonLaster]

This should be fixed now with tabs.