Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

In the Call stack panel, Groups should have a title #7209

Closed
nchevobbe opened this issue Oct 31, 2018 · 0 comments
Closed

In the Call stack panel, Groups should have a title #7209

nchevobbe opened this issue Oct 31, 2018 · 0 comments
Assignees

Comments

@nchevobbe
Copy link
Member

In https://github.com/devtools-html/debugger.html/blob/6daa22e0253ab6e30f8d250784e59ae6cbf4327e/src/components/SecondaryPanes/Frames/Group.js#L128-L133

we should have a title attribute which would contain the following: Show all ${frame.library} frames / Collapse ${frame.library} frames.

In order to do that, 2 new strings should be added in debugger.properties, (e.g. callStack.group.expandTooltip and callStack.group.collapseTooltip):

callStack.group.expandTooltip=Show all %S frames

Then, in Group.js, L10N.getFormatStr("callStack.group.expandTooltip", frame.library) can be used to replace the %S with the library name.

@claim claim bot added the not-available label Oct 31, 2018
@nchevobbe nchevobbe self-assigned this Nov 16, 2018
nchevobbe added a commit to nchevobbe/debugger.html that referenced this issue Nov 16, 2018
Fixes firefox-devtools#7209.

This adds a title to the group component
that indicates it can be expanded/collapsed.
Two location entries are added to handle both
collapsed and expanded state.
nchevobbe added a commit to nchevobbe/debugger.html that referenced this issue Nov 16, 2018
Fixes firefox-devtools#7209.

This adds a title to the group component
that indicates it can be expanded/collapsed.
Two location entries are added to handle both
collapsed and expanded state.
nchevobbe added a commit that referenced this issue Nov 16, 2018
Fixes #7209.

This adds a title to the group component
that indicates it can be expanded/collapsed.
Two location entries are added to handle both
collapsed and expanded state.
loganfsmyth pushed a commit that referenced this issue Nov 16, 2018
Fixes #7209.

This adds a title to the group component
that indicates it can be expanded/collapsed.
Two location entries are added to handle both
collapsed and expanded state.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants