Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Consolidate Icon CSS Files #7735

Closed
darkwing opened this issue Jan 16, 2019 · 7 comments · Fixed by #7890
Closed

Consolidate Icon CSS Files #7735

darkwing opened this issue Jan 16, 2019 · 7 comments · Fixed by #7890

Comments

@darkwing
Copy link
Contributor

At the moment we have three files which contain CSS for icon display:

  • src/components/shared/SourceIcon.css
  • src/components/shared/Svg.css
  • src/components/PrimaryPanes/Sources.css

There's unnecessary overlap in some of their styles which we should resolve. Ideally we have one CSS file with all of the base icon stuff.

@darkwing
Copy link
Contributor Author

@notjaril You may enjoy this one 👍

@jaril
Copy link
Contributor

jaril commented Jan 17, 2019

/claim

@claim
Copy link

claim bot commented Jan 17, 2019

Thanks for claiming the issue! 👋

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

🦊 Debugger team!

@jasonLaster
Copy link
Contributor

I'm re-opening because I could not land the Accordion.css changes in MC

This commit shows the portion that i had to revert in debugger.css and Accordion.css.
https://hg.mozilla.org/mozilla-central/rev/1c7af47c1ba4

The reason for the revert was that this test (browser_dbg-expressions-focus.js) was failing with it.
The best path forwards is to try to re-land the debugger.css changes in MC.

@darkwing
Copy link
Contributor Author

darkwing commented Feb 12, 2019

@fvsch ^

@fvsch
Copy link
Contributor

fvsch commented Feb 13, 2019

(Side note: we should probably update assignee (me) and labels.)

Just to be clear, commit 3d9f98d shows what was reverted too?

@fvsch
Copy link
Contributor

fvsch commented Feb 13, 2019

I swear if the issue is that I changed the accordion headers from 24px to 25px height and some clickAtPreciseCoordinatesBecauseWhatCouldGoWrongAmarite(0,25) code is failing, I'm going to shout at some clouds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants